test(graph): golden-fixture accuracy harness for rc/trace/dead-code (closes #277) - #280
Merged
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Mengapa
Fondasi call-graph retak berulang tanpa tertangkap CI (#210/#219/#220/#222/#223/#231 — semua edge/caller hilang, ditemukan manual berbulan kemudian). Tak ada test yang mengunci output graph pada fixture dikenal.
Isi
tests/test_graph_accuracy_golden.py— fixture polyglot kecil deterministik untuk pola yang HISTORIS bikin bug, assert nilai KONKRET:moduleLevelHelperrc>=2 + caller dari mod_level.tsgetGoogleClientrc>=1 + caller dari handler.tsservice.listItemsteregistrasidetect_dead_code(assert di layer engine yang user konsumsi, bukan raw node status)Verifikasi + temuan
5 passed. Harness sudah membuktikan nilainya hari pertama: memunculkan bahwa dead-code punya DUA layer — raw
backend.jsonnodestatus(const rc 0, benar) vs enginedetect_dead_code(#220 exemption, RED tidak dilaporkan). Assert di-set ke layer yang benar (yang user pakai). Cross-platform (normalize separator).Revert salah satu fix #219/#231/#222/#220 → test gagal seketika, bukan berbulan kemudian.
Closes #277